test/cctest/cctest.h - Issue 135153007: Dispose Isolate at end of cctest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/cctest.h

Issue 135153007: Dispose Isolate at end of cctest. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/cctest.h

diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h

index 6c67dd52ec4094d7e6805266879e1d92b3f20cfb..d9f76294e1a5d432db4b2fdf9127d39630a02e00 100644

--- a/test/cctest/cctest.h

+++ b/test/cctest/cctest.h

@@ -131,8 +131,7 @@ class CcTest {

v8::Isolate* isolate = CcTest::isolate());

static void TearDown() {

- // TODO(svenpanne) Enable this when our cctests are fixed.

- // if (isolate_ != NULL) isolate_->Dispose();

+ if (isolate_ != NULL) isolate_->Dispose();

}

private:

« no previous file with comments | « no previous file | no next file » | no next file with comments »