Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: test/cctest/cctest.h

Issue 135153007: Dispose Isolate at end of cctest. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 // Only for UNINITIALIZED_TESTs 124 // Only for UNINITIALIZED_TESTs
125 static void DisableAutomaticDispose(); 125 static void DisableAutomaticDispose();
126 126
127 // Helper function to configure a context. 127 // Helper function to configure a context.
128 // Must be in a HandleScope. 128 // Must be in a HandleScope.
129 static v8::Local<v8::Context> NewContext( 129 static v8::Local<v8::Context> NewContext(
130 CcTestExtensionFlags extensions, 130 CcTestExtensionFlags extensions,
131 v8::Isolate* isolate = CcTest::isolate()); 131 v8::Isolate* isolate = CcTest::isolate());
132 132
133 static void TearDown() { 133 static void TearDown() {
134 // TODO(svenpanne) Enable this when our cctests are fixed. 134 if (isolate_ != NULL) isolate_->Dispose();
135 // if (isolate_ != NULL) isolate_->Dispose();
136 } 135 }
137 136
138 private: 137 private:
139 friend int main(int argc, char** argv); 138 friend int main(int argc, char** argv);
140 TestFunction* callback_; 139 TestFunction* callback_;
141 const char* file_; 140 const char* file_;
142 const char* name_; 141 const char* name_;
143 const char* dependency_; 142 const char* dependency_;
144 bool enabled_; 143 bool enabled_;
145 bool initialize_; 144 bool initialize_;
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 CHECK_EQ(0, heap_profiler_->heap_object_map()->FindUntrackedObjects()); 371 CHECK_EQ(0, heap_profiler_->heap_object_map()->FindUntrackedObjects());
373 heap_profiler_->StopHeapObjectsTracking(); 372 heap_profiler_->StopHeapObjectsTracking();
374 } 373 }
375 374
376 private: 375 private:
377 i::HeapProfiler* heap_profiler_; 376 i::HeapProfiler* heap_profiler_;
378 }; 377 };
379 378
380 379
381 #endif // ifndef CCTEST_H_ 380 #endif // ifndef CCTEST_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698