Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1351363002: Fix the typo "visibility". (Closed)

Created:
5 years, 3 months ago by Avi (use Gerrit)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, sadrul, tfarina, mlamouri+watch-notifications_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, yzshen+watch_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, penghuang+watch-mandoline_chromium.org, kalyank, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the typo "visibility". BUG=none TEST=none Committed: https://crrev.com/56603fe126f74bb67c6152304ef3b087449d1324 Cr-Commit-Position: refs/heads/master@{#349767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
M ash/wm/lock_state_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_state.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_common.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_tabrestore_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/tab-restore-visibility.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/tab-restore-visibilty.html View 1 chunk +0 lines, -6 lines 0 comments Download
M mandoline/ui/aura/native_widget_view_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_button_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/touch_selection/touch_handle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351363002/1
5 years, 3 months ago (2015-09-18 19:11:57 UTC) #2
Avi (use Gerrit)
Can you rubber-stamp this?
5 years, 3 months ago (2015-09-18 19:30:06 UTC) #4
Ben Goodger (Google)
lgtm
5 years, 3 months ago (2015-09-18 20:16:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 20:25:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351363002/1
5 years, 3 months ago (2015-09-18 21:03:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 21:10:56 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/56603fe126f74bb67c6152304ef3b087449d1324 Cr-Commit-Position: refs/heads/master@{#349767}
5 years, 3 months ago (2015-09-18 21:11:28 UTC) #11
michaelpg
"visiblity" has even more hits ;-)
5 years, 3 months ago (2015-09-18 21:17:20 UTC) #12
Avi (use Gerrit)
On 2015/09/18 21:17:20, michaelpg wrote: > "visiblity" has even more hits ;-) Go fix it! ...
5 years, 3 months ago (2015-09-18 21:18:01 UTC) #13
michaelpg
5 years, 3 months ago (2015-09-18 21:33:51 UTC) #14
Message was sent while issue was closed. 
On 2015/09/18 21:18:01, Avi wrote:
> On 2015/09/18 21:17:20, michaelpg wrote:
> > "visiblity" has even more hits ;-)
> 
> Go fix it! :)

Happy to. You're talking to an english-readability-reviewer, after all!

Powered by Google App Engine
This is Rietveld 408576698