Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1351313003: Revert "Revert of Expose distiller functions to JavaScript..." (Closed)

Created:
5 years, 3 months ago by mdjones
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Expose distiller functions to JavaScript This change adds two mojo services; one for notifying a RenderFrame that it is working on a distiller page and one for allowing distiller JavaScript functions to access the browser. This CL only exposes a single function "distiller.echo". This reverts commit 5b77e8f46f38eb1592b17ec2e2fe97a148d96a65 and should fix the GN build that broke. Initial review: https://codereview.chromium.org/1231083007/ TBR=jochen Committed: https://crrev.com/28f3694cf6796d840cb4296441d26f63c2ce50c2 Cr-Commit-Position: refs/heads/master@{#350418}

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+667 lines, -11 lines) Patch
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 3 chunks +66 lines, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M components/dom_distiller.gypi View 4 chunks +44 lines, -2 lines 0 comments Download
M components/dom_distiller/content/BUILD.gn View 1 3 chunks +41 lines, -2 lines 0 comments Download
A + components/dom_distiller/content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A components/dom_distiller/content/browser/distiller_javascript_service_impl.h View 1 chunk +34 lines, -0 lines 0 comments Download
A components/dom_distiller/content/browser/distiller_javascript_service_impl.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc View 5 chunks +20 lines, -4 lines 0 comments Download
A components/dom_distiller/content/common/distiller_javascript_service.mojom View 1 chunk +11 lines, -0 lines 0 comments Download
A components/dom_distiller/content/common/distiller_page_notifier_service.mojom View 1 chunk +11 lines, -0 lines 0 comments Download
A + components/dom_distiller/content/renderer/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
A components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h View 1 chunk +60 lines, -0 lines 0 comments Download
A components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A components/dom_distiller/content/renderer/distiller_native_javascript.h View 1 chunk +42 lines, -0 lines 0 comments Download
A components/dom_distiller/content/renderer/distiller_native_javascript.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h View 1 chunk +38 lines, -0 lines 0 comments Download
A components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +53 lines, -0 lines 0 comments Download
M content/renderer/dom_automation_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/dom_automation_controller.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
mdjones
My previous CL (https://codereview.chromium.org/1231083007/) had to be reverted due to a build issue on windows. ...
5 years, 3 months ago (2015-09-19 01:20:54 UTC) #2
nyquist
lgtm Regarding the commit message, could you change it to something like: ### Reland: Expose ...
5 years, 3 months ago (2015-09-21 02:54:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351313003/40001
5 years, 3 months ago (2015-09-23 22:13:13 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-24 00:48:32 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 00:49:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/28f3694cf6796d840cb4296441d26f63c2ce50c2
Cr-Commit-Position: refs/heads/master@{#350418}

Powered by Google App Engine
This is Rietveld 408576698