Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1351313002: Allow 'chrome-extension:' URLs to bypass content settings (1/2) (Closed)

Created:
5 years, 3 months ago by Mike West
Modified:
5 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Merge "Allow 'chrome-extension:' URLs to bypass content settings (1/2)" to M46. > We changed the behavior of 'Document::firstPartyForCookies' to return an > empty URL in the case where any URL in the ancestor chain doesn't match > the current document's URL. Previously, we'd simply return the top-level > document's URL. > > This means that the content-settings bypass check in > 'ContentSettingsObserver::IsWhitelistedForContentSettings' sees an empty > URL as opposed to a 'chrome-extension://' URL for cases in which an > extension loads a resource, so content settings are applied as per usual. > This breaks things fairly badly for folks who have turned on third-party > cookie blocking. > > In these patches, we introduce a new scheme registry for those schemes > which ought to override Blink's concept of "first-party" when they're > loaded into the top-level browsing context. > > Patch 1 (Blink): https://codereview.chromium.org/1305253012 > Patch 2 (Chromium): [This patch] > > BUG=527963 > R=jochen@chromium.org > > Review URL: https://codereview.chromium.org/1332563006 Cr-Commit-Position: refs/heads/master@{#348194} (cherry picked from commit cfed7a300606c5eedb858433b37db5ffadf3b2cc) Note: Moved the call of this method from Dispatcher::WebKitInitialized() to Dispatcher::Dispatcher(), which is where the similar methods were at this point in history. TBR=amineer@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c82b0ab685fef68670557b095dfc960f2086417f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M extensions/renderer/dispatcher.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mike West
5 years, 3 months ago (2015-09-18 09:03:07 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c82b0ab685fef68670557b095dfc960f2086417f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698