Allow 'chrome-extension:' URLs to bypass content settings (2/2)

Allow 'chrome-extension:' URLs to bypass content settings (1/2)

We changed the behavior of 'Document::firstPartyForCookies' to return an
empty URL in the case where any URL in the ancestor chain doesn't match
the current document's URL. Previously, we'd simply return the top-level
document's URL.

This means that the content-settings bypass check in
'ContentSettingsObserver::IsWhitelistedForContentSettings' sees an empty
URL as opposed to a 'chrome-extension://' URL for cases in which an
extension loads a resource, so content settings are applied as per usual.
This breaks things fairly badly for folks who have turned on third-party
cookie blocking.

In these patches, we introduce a new scheme registry for those schemes
which ought to override Blink's concept of "first-party" when they're
loaded into the top-level browsing context.

Patch 1 (Blink): https://codereview.chromium.org/1305253012
Patch 2 (Chromium): [This patch]

BUG=527963
R=jochen@chromium.org

Committed: https://crrev.com/cfed7a300606c5eedb858433b37db5ffadf3b2cc
Cr-Commit-Position: refs/heads/master@{#348194}

[Mike West, 2015-09-09 07:36:36]

mkwst@chromium.org changed reviewers:
+ kalman@chromium.org

[Mike West, 2015-09-09 07:36:36]

Mind taking a look, Ben, or Jochen?

[jochen (gone - plz use gerrit), 2015-09-09 07:41:52]

lgtm

[Mike West, 2015-09-09 10:23:13]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-09-09 10:23:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1332563006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1332563006/1

[commit-bot: I haz the power, 2015-09-09 10:32:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-09 10:32:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mike West, 2015-09-09 12:38:30]

Ah, Ben, I do need your stamp. Jochen isn't cool enough, and neither am I. :(

[not at google - send to devlin, 2015-09-09 18:06:52]

lgtm but note merge conflict.

https://codereview.chromium.org/1332563006/diff/1/extensions/renderer/dispatc...
File extensions/renderer/dispatcher.cc (right):

https://codereview.chromium.org/1332563006/diff/1/extensions/renderer/dispatc...
extensions/renderer/dispatcher.cc:257: RegisterFunction register_functions[] = {
This has moved into WebkitInitialized.

[Mike West, 2015-09-10 06:45:34]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-09-10 06:45:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1332563006/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-09-10 06:45:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1332563006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1332563006/20001

[commit-bot: I haz the power, 2015-09-10 07:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-10 07:55:40]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mike West, 2015-09-10 17:54:18]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-09-10 17:55:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1332563006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1332563006/20001

[commit-bot: I haz the power, 2015-09-10 18:26:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-10 18:27:35]

Patchset 2 (id:??) landed as
https://crrev.com/cfed7a300606c5eedb858433b37db5ffadf3b2cc
Cr-Commit-Position: refs/heads/master@{#348194}

[commit-bot: I haz the power, 2015-09-23 12:12:25]

Patchset 2 (id:??) landed as
https://crrev.com/cfed7a300606c5eedb858433b37db5ffadf3b2cc
Cr-Commit-Position: refs/heads/master@{#348194}