Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: chrome/android/java/res/layout/interests_page.xml

Issue 1351303003: Add the UI for the Interests Prototype. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp-interests-jni
Patch Set: Fetch the oauth token from the native code. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/res/values/dimens.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/interests_page.xml
diff --git a/chrome/android/java/res/layout/interests_page.xml b/chrome/android/java/res/layout/interests_page.xml
new file mode 100644
index 0000000000000000000000000000000000000000..096c9869507922fedc88fcf135c488d6c592dd82
--- /dev/null
+++ b/chrome/android/java/res/layout/interests_page.xml
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<org.chromium.chrome.browser.ntp.InterestsPageView
newt (away) 2015/09/29 17:33:21 InterestsPageView should be a FrameLayout (which i
PEConn 2015/11/18 15:26:56 Done.
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ android:id="@+id/interests_content"
newt (away) 2015/09/29 17:33:21 nit: don't add an ID unless you're going to use it
PEConn 2015/11/18 15:26:56 Done.
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:paddingTop="@dimen/tab_strip_height"
+ android:orientation="vertical"
+ android:focusable="true"
+ android:focusableInTouchMode="true" >
+
+ <GridView xmlns:android="http://schemas.android.com/apk/res/android"
newt (away) 2015/09/29 17:33:21 remove redundant xmlns attribute (it's only needed
PEConn 2015/11/18 15:26:56 Done.
+ android:id="@+id/interests_list_view"
newt (away) 2015/09/29 17:33:21 indentation should look like this: <org.chromium.
PEConn 2015/11/18 15:26:56 Done.
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:paddingTop="@dimen/toolbar_height_no_shadow"
+ android:numColumns="2"
+ android:verticalSpacing="10dp"
+ android:horizontalSpacing="10dp"
+ android:stretchMode="columnWidth"
+ android:gravity="center" />
+
+</org.chromium.chrome.browser.ntp.InterestsPageView>
« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/res/values/dimens.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698