chrome/android/java/res/layout/interests_page.xml - Issue 1351303003: Add the UI for the Interests Prototype.

Side by Side Diff: chrome/android/java/res/layout/interests_page.xml

Issue 1351303003: Add the UI for the Interests Prototype. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntp-interests-jni

Patch Set: Fetch the oauth token from the native code. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.ntp.InterestsPageView
	newt (away) 2015/09/29 17:33:21 InterestsPageView should be a FrameLayout (which i InterestsPageView should be a FrameLayout (which is simpler) since it only has a single child. (and remove android:orientation too, sine that doesn't apply to FrameLayouts) PEConn 2015/11/18 15:26:56 Done. Show quoted text On 2015/09/29 17:33:21, newt wrote: > InterestsPageView should be a FrameLayout (which is simpler) since it only has a > single child. (and remove android:orientation too, sine that doesn't apply to > FrameLayouts) Done.
	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:id="@+id/interests_content"
	newt (away) 2015/09/29 17:33:21 nit: don't add an ID unless you're going to use it nit: don't add an ID unless you're going to use it. Leaving out the ID makes it clear that the view isn't manipulated programmatically, which is helpful to know. PEConn 2015/11/18 15:26:56 Done. Show quoted text On 2015/09/29 17:33:21, newt wrote: > nit: don't add an ID unless you're going to use it. Leaving out the ID makes it > clear that the view isn't manipulated programmatically, which is helpful to > know. Done.
	9 android:layout_width="match_parent"

	10 android:layout_height="match_parent"

	11 android:paddingTop="@dimen/tab_strip_height"

	12 android:orientation="vertical"

	13 android:focusable="true"

	14 android:focusableInTouchMode="true" >

	15

	16 <GridView xmlns:android="http://schemas.android.com/apk/res/android"
	newt (away) 2015/09/29 17:33:21 remove redundant xmlns attribute (it's only needed remove redundant xmlns attribute (it's only needed on the root element in the file) PEConn 2015/11/18 15:26:56 Done. Show quoted text On 2015/09/29 17:33:21, newt wrote: > remove redundant xmlns attribute (it's only needed on the root element in the > file) Done.
	17 android:id="@+id/interests_list_view"
	newt (away) 2015/09/29 17:33:21 indentation should look like this: <org.chromium. indentation should look like this: <org.chromium.chrome.browser.ntp.InterestsPageView xmlns:android="http://schemas.android.com/apk/res/android" ... /> <GridView android:id="@+id/interests_list_view" ... /> </org.chromium.chrome.browser.ntp.InterestsPageView> PEConn 2015/11/18 15:26:56 Done. Show quoted text On 2015/09/29 17:33:21, newt wrote: > indentation should look like this: > > <org.chromium.chrome.browser.ntp.InterestsPageView > xmlns:android="http://schemas.android.com/apk/res/android" > ... /> > > <GridView > android:id="@+id/interests_list_view" > ... /> > > </org.chromium.chrome.browser.ntp.InterestsPageView> Done.
	18 android:layout_width="match_parent"

	19 android:layout_height="match_parent"

	20 android:paddingTop="@dimen/toolbar_height_no_shadow"

	21 android:numColumns="2"

	22 android:verticalSpacing="10dp"

	23 android:horizontalSpacing="10dp"

	24 android:stretchMode="columnWidth"

	25 android:gravity="center" />

	26

	27 </org.chromium.chrome.browser.ntp.InterestsPageView>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/res/values/dimens.xml » ('J')