Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 135123017: A64: Remove Assembler::finalized_ flag and logic (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Remove Assembler::finalized_ flag and logic The flag is supposed to check that the assembled code was used. However, codegen uses masm::CodeObject() to retrieve the code which is not detected by this logic. We could make CodeObject() set finalized_ as wel, however, it's used all over the place which would make the flag worthless. BUG=none R=rodolph.perfetta@arm.com, ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M src/a64/assembler-a64.h View 5 chunks +0 lines, -22 lines 0 comments Download
M src/a64/assembler-a64.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-10 21:19:12 UTC) #1
Rodolph Perfetta (ARM)
lgtm
6 years, 10 months ago (2014-02-11 09:17:01 UTC) #2
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-11 09:25:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19261 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698