Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/a64/assembler-a64.h

Issue 135123017: A64: Remove Assembler::finalized_ flag and logic (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/a64/assembler-a64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/assembler-a64.h
diff --git a/src/a64/assembler-a64.h b/src/a64/assembler-a64.h
index c65f62dded0bc515f22acb0664e1cb0c85dc3e2e..f8d8f127c4e6f60c46d34cad26222647db5d6d3d 100644
--- a/src/a64/assembler-a64.h
+++ b/src/a64/assembler-a64.h
@@ -701,10 +701,6 @@ class Assembler : public AssemblerBase {
// upon destruction of the assembler.
Assembler(Isolate* arg_isolate, void* buffer, int buffer_size);
- // The default destructor asserts that one of the following is true:
- // * The Assembler object has not been used.
- // * Nothing has been emitted since the last Reset() call.
- // * Nothing has been emitted since the last GetCode() call.
virtual ~Assembler();
// System functions ---------------------------------------------------------
@@ -1882,10 +1878,6 @@ class Assembler : public AssemblerBase {
STATIC_ASSERT(sizeof(instruction) == kInstructionSize);
ASSERT((pc_ + sizeof(instruction)) <= (buffer_ + buffer_size_));
-#ifdef DEBUG
- finalized_ = false;
-#endif
-
memcpy(pc_, &instruction, sizeof(instruction));
pc_ += sizeof(instruction);
CheckBuffer();
@@ -1896,10 +1888,6 @@ class Assembler : public AssemblerBase {
ASSERT(sizeof(*pc_) == 1);
ASSERT((pc_ + size) <= (buffer_ + buffer_size_));
-#ifdef DEBUG
- finalized_ = false;
-#endif
-
// TODO(all): Somehow register we have some data here. Then we can
// disassemble it correctly.
memcpy(pc_, data, size);
@@ -1994,10 +1982,6 @@ class Assembler : public AssemblerBase {
// stream.
static const int kGap = 128;
-#ifdef DEBUG
- bool finalized_;
-#endif
-
private:
// TODO(jbramley): VIXL uses next_literal_pool_check_ and
// literal_pool_monitor_ to determine when to consider emitting a literal
@@ -2047,12 +2031,6 @@ class PatchingAssembler : public Assembler {
// Flush the Instruction cache.
size_t length = buffer_size_ - kGap;
CPU::FlushICache(buffer_, length);
-
-#ifdef DEBUG
- // The Patching Assembler doesn't need to be finalized, but the Assembler
- // class's destructor will check the finalized_ flag.
- finalized_ = true;
-#endif
}
};
« no previous file with comments | « no previous file | src/a64/assembler-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698