Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: fpdfsdk/src/fsdk_mgr.cpp

Issue 1351173002: XFA: contention between FXJSE and FXJS over isolate data slots (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/fsdk_mgr.cpp
diff --git a/fpdfsdk/src/fsdk_mgr.cpp b/fpdfsdk/src/fsdk_mgr.cpp
index 4a55622e577c684067c8e498f643e5499adb5ca9..e922129cb8deaa85ff7d933a8cf9feaa3163e42c 100644
--- a/fpdfsdk/src/fsdk_mgr.cpp
+++ b/fpdfsdk/src/fsdk_mgr.cpp
@@ -225,10 +225,8 @@ CPDFDoc_Environment::~CPDFDoc_Environment() {
if (m_pJSRuntime && pProvider->GetRuntimeFactory())
pProvider->GetRuntimeFactory()->DeleteJSRuntime(m_pJSRuntime);
- if (pProvider->m_pEnvList.GetSize() == 0) {
- pProvider->ReleaseRuntime();
- pProvider->InitRuntime(TRUE);
- }
+ if (pProvider->m_pEnvList.GetSize() == 0)
+ pProvider->SetJavaScriptInitialized(FALSE);
delete m_pSysHandler;
m_pSysHandler = NULL;

Powered by Google App Engine
This is Rietveld 408576698