Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1351143006: clang packager/win: Check that GnuWin32 is in the path at the start. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang packager/win: Check that GnuWin32 is in the path at the start. It's needed to run tests, and I prefer getting an error message immediately over getting one 17 minutes in, when the build is done and tests start running. BUG=82385 Committed: https://crrev.com/fc8254be282454c26a228545fca479e3b257daaa Cr-Commit-Position: refs/heads/master@{#349932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/clang/scripts/package.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 3 months ago (2015-09-19 04:54:06 UTC) #2
hans
lgtm Huh, I was sure we had added this before.
5 years, 3 months ago (2015-09-21 15:14:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351143006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351143006/1
5 years, 3 months ago (2015-09-21 15:18:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 15:35:32 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 15:36:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc8254be282454c26a228545fca479e3b257daaa
Cr-Commit-Position: refs/heads/master@{#349932}

Powered by Google App Engine
This is Rietveld 408576698