Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/clang/scripts/package.py

Issue 1351143006: clang packager/win: Check that GnuWin32 is in the path at the start. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/package.py
diff --git a/tools/clang/scripts/package.py b/tools/clang/scripts/package.py
index 74fc409ebcc3092b5b3191b789dd1e4c25781658..be8498f527e123da01ccffcf952ea5472d8e1a9e 100755
--- a/tools/clang/scripts/package.py
+++ b/tools/clang/scripts/package.py
@@ -58,6 +58,13 @@ def PrintTarProgress(tarinfo):
def main():
+ if sys.platform == 'win32':
+ try:
+ subprocess.check_output(['grep', '--help'], shell=True)
+ except subprocess.CalledProcessError:
+ print 'Add gnuwin32 to your PATH, then try again.'
+ return 1
+
parser = argparse.ArgumentParser(description='build and package clang')
parser.add_argument('--gcc-toolchain',
help="the prefix for the GCC version used for building. "
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698