Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 135113002: Undo the mistake of early return in GetFaviconResourceBytes. (Closed)

Created:
6 years, 11 months ago by aurimas (slooooooooow)
Modified:
6 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Undo the mistake of early return in GetFaviconResourceBytes. When trying to enable chrome://components for Android "return NULL;" was accidentally moved together with the if check resulting in an early return. Breaking CL https://codereview.chromium.org/112673008 BUG=332714 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
aurimas (slooooooooow)
Hey Evan, Please take a look at this small CL. Thanks, Aurimas
6 years, 11 months ago (2014-01-10 23:15:49 UTC) #1
Evan Stade
lgtm
6 years, 11 months ago (2014-01-11 00:43:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/135113002/1
6 years, 11 months ago (2014-01-11 02:02:34 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 03:02:17 UTC) #4
Message was sent while issue was closed.
Change committed as 244425

Powered by Google App Engine
This is Rietveld 408576698