Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 112673008: Revert 242262 "Revert of https://codereview.chromium.org/119913003/" (Closed)

Created:
6 years, 11 months ago by aurimas (slooooooooow)
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 242262 "Revert of https://codereview.chromium.org/119913003/" reland r242237 that got reverted in r242262. > Revert of https://codereview.chromium.org/119913003/ > Reason for revert: Broke ComponentUpdaterTest on Android. Need to update expectations. > > TBR=cpu@chromium.org,thakis@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=116838 > > Review URL: https://codereview.chromium.org/120433002 TBR=aurimas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M trunk/src/chrome/browser/browser_resources.grd View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/chrome_browser_main.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M trunk/src/chrome/common/url_constants.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
aurimas (slooooooooow)
6 years, 11 months ago (2014-01-07 01:25:34 UTC) #1
aurimas (slooooooooow)
6 years, 11 months ago (2014-01-07 01:25:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r243217.

Powered by Google App Engine
This is Rietveld 408576698