Oilpan: Remove 'inline' from Heap::allocateOnHeapIndex

Oilpan: Remove 'inline' from Heap::allocateOnHeapIndex

For some reason I don't know, this CL improves performance of
document.createElement("div") by 10% and thus fix regressions
observed in Dromaeo/dom-modify.html.

BUG=

[haraken, 2015-09-17 10:26:49]

haraken@chromium.org changed reviewers:
+ keishi@chromium.org

[haraken, 2015-09-17 10:26:49]

PTAL

keishi@: Would you measure the performance of Bindings/create-element.html with
the following settings?

- ToT with oilpan
- ToT + this CL with oilpan

If this CL improves performance in your environment as well, I propose to land
this CL.

[sof, 2015-09-17 10:47:52]

Does this one perturb blink_perf.dom.textarea-dom numbers also?

[haraken, 2015-09-17 10:51:53]

On 2015/09/17 10:47:52, sof wrote:
> Does this one perturb blink_perf.dom.textarea-dom numbers also?

Unfortunately the numbers of textarea-dom didn't change...

[keishi, 2015-09-18 05:12:08]

Here are my results.
Bindings/create-element.html regression gone.
CSS tests are better too.
no change for textarea-dom
https://www.googledrive.com/host/0B4aiM9jljUy8UEh0QjR3SUVXaVE/linux-0917-resu...

[haraken, 2015-09-18 05:24:38]

On 2015/09/18 05:12:08, keishi wrote:
> Here are my results.
> Bindings/create-element.html regression gone.
> CSS tests are better too.
> no change for textarea-dom
>
https://www.googledrive.com/host/0B4aiM9jljUy8UEh0QjR3SUVXaVE/linux-0917-resu...

Thanks! Then PTAL :)

[sof, 2015-09-18 05:44:06]

On 2015/09/18 05:24:38, haraken wrote:
> On 2015/09/18 05:12:08, keishi wrote:
> > Here are my results.
> > Bindings/create-element.html regression gone.
> > CSS tests are better too.
> > no change for textarea-dom
> >
>
https://www.googledrive.com/host/0B4aiM9jljUy8UEh0QjR3SUVXaVE/linux-0917-resu...
> 
> Thanks! Then PTAL :)

What level of confidence do you have that the observed improvements will carry
over to other platforms? (I'm fine with landing this, but that we keep this
change in mind when looking & reconciling perf data on other platforms later.)

[haraken, 2015-09-18 05:46:35]

On 2015/09/18 05:44:06, sof wrote:
> On 2015/09/18 05:24:38, haraken wrote:
> > On 2015/09/18 05:12:08, keishi wrote:
> > > Here are my results.
> > > Bindings/create-element.html regression gone.
> > > CSS tests are better too.
> > > no change for textarea-dom
> > >
> >
>
https://www.googledrive.com/host/0B4aiM9jljUy8UEh0QjR3SUVXaVE/linux-0917-resu...
> > 
> > Thanks! Then PTAL :)
> 
> What level of confidence do you have that the observed improvements will carry
> over to other platforms? (I'm fine with landing this, but that we keep this
> change in mind when looking & reconciling perf data on other platforms later.)

keishi-san: Would you just check if this CL improves create-elememt.html in Mac?

[keishi, 2015-09-18 05:53:39]

On 2015/09/18 05:46:35, haraken wrote:
> On 2015/09/18 05:44:06, sof wrote:
> > On 2015/09/18 05:24:38, haraken wrote:
> > > On 2015/09/18 05:12:08, keishi wrote:
> > > > Here are my results.
> > > > Bindings/create-element.html regression gone.
> > > > CSS tests are better too.
> > > > no change for textarea-dom
> > > >
> > >
> >
>
https://www.googledrive.com/host/0B4aiM9jljUy8UEh0QjR3SUVXaVE/linux-0917-resu...
> > > 
> > > Thanks! Then PTAL :)
> > 
> > What level of confidence do you have that the observed improvements will
carry
> > over to other platforms? (I'm fine with landing this, but that we keep this
> > change in mind when looking & reconciling perf data on other platforms
later.)
> 
> keishi-san: Would you just check if this CL improves create-elememt.html in
Mac?

ok

[haraken, 2015-09-24 01:28:16]

On 2015/09/18 05:53:39, keishi wrote:
> On 2015/09/18 05:46:35, haraken wrote:
> > On 2015/09/18 05:44:06, sof wrote:
> > > On 2015/09/18 05:24:38, haraken wrote:
> > > > On 2015/09/18 05:12:08, keishi wrote:
> > > > > Here are my results.
> > > > > Bindings/create-element.html regression gone.
> > > > > CSS tests are better too.
> > > > > no change for textarea-dom
> > > > >
> > > >
> > >
> >
>
https://www.googledrive.com/host/0B4aiM9jljUy8UEh0QjR3SUVXaVE/linux-0917-resu...
> > > > 
> > > > Thanks! Then PTAL :)
> > > 
> > > What level of confidence do you have that the observed improvements will
> carry
> > > over to other platforms? (I'm fine with landing this, but that we keep
this
> > > change in mind when looking & reconciling perf data on other platforms
> later.)
> > 
> > keishi-san: Would you just check if this CL improves create-elememt.html in
> Mac?
> 
> ok

Reuploaded to https://codereview.chromium.org/1367753004/ after the repo merge.