Issue 1350963004: Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords, attempt 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1350963004: Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords, attempt 2 (Closed)

Created:
5 years, 3 months ago by cbiesinger

Modified:
5 years, 2 months ago

Reviewers:
Yoav Weiss, esprehn

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, jfernandez, Manuel Rego, rwlbuis, svillar

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords, attempt 2 Intent to deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion Depends on https://codereview.chromium.org/1359463003/ This is a different approach than in https://codereview.chromium.org/1314923005 which had to be reverted due to leaks. R=esprehn@chromium.org,yoav@yoav.ws BUG=475104

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -3 lines)			Patch
M	LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/css/deprecated-flex-box-zero-width-intrinsic-max-width-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/parser/LegacyCSSPropertyParser.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleAdjuster.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View	1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

esprehn

5 years, 3 months ago (2015-09-19 01:25:56 UTC) #2

This kind of sucks since it makes all style recalc slower by adding a bunch of
extra branches for every element. We don't usually do this...

https://codereview.chromium.org/1350963004/diff/1/Source/core/frame/UseCounte...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1350963004/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:951: case LegacyCSSValueMinIntrinsic:
Where does this case get handled? I only see the LegacyCSSValueIntrinsic enum
value used in StyleAdjuster.

Expand Messages | Collapse Messages