Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314923005: Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords (Closed)

Created:
5 years, 4 months ago by cbiesinger
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords Intent to deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion I plan to merge this to the M46 branch ASAP. R=esprehn@chromium.org,yoav@yoav.ws BUG=475104 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201259

Patch Set 1 #

Total comments: 2

Patch Set 2 : more typo fixes #

Patch Set 3 : update tests #

Patch Set 4 : one more test #

Patch Set 5 : a couple more tests... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -35 lines) Patch
M LayoutTests/fast/block/marquee-width-shrinks-to-fit-in-fixed-size-container.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/multicol-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/resources/width-keyword-classes.css View 1 2 4 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/css/deprecated-flex-box-zero-width-intrinsic-max-width-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/zoomed-intrinsic-width.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/zoomed-intrinsic-width-expected.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/html/element-offset-expected.txt View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/table/cell-height-min-intrinsic.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/tab-min-size.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/svg-width-intrinsic-crash.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGroupingRule.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/CSSKeyframesRule.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/CSSPageRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserMode.h View 1 2 3 4 4 chunks +6 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParserMode.cpp View 3 chunks +10 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 57 (26 generated)
cbiesinger
5 years, 4 months ago (2015-08-25 20:59:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/1
5 years, 4 months ago (2015-08-25 21:00:06 UTC) #3
jbroman
just one drive-by question https://codereview.chromium.org/1314923005/diff/1/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1314923005/diff/1/Source/core/frame/UseCounter.cpp#newcode948 Source/core/frame/UseCounter.cpp:948: return "'Element.offsetParent' is deprecated and ...
5 years, 4 months ago (2015-08-25 21:04:06 UTC) #4
cbiesinger
https://codereview.chromium.org/1314923005/diff/1/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1314923005/diff/1/Source/core/frame/UseCounter.cpp#newcode948 Source/core/frame/UseCounter.cpp:948: return "'Element.offsetParent' is deprecated and will be removed in ...
5 years, 4 months ago (2015-08-25 21:06:43 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/20001
5 years, 4 months ago (2015-08-25 21:08:16 UTC) #7
Yoav Weiss
On 2015/08/25 21:08:16, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 4 months ago (2015-08-25 21:53:48 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104183)
5 years, 4 months ago (2015-08-25 21:56:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/60001
5 years, 4 months ago (2015-08-25 22:16:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/89878)
5 years, 4 months ago (2015-08-25 22:31:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/60001
5 years, 4 months ago (2015-08-25 22:32:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/73751) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-25 22:33:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/60001
5 years, 4 months ago (2015-08-25 22:35:18 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/54749)
5 years, 4 months ago (2015-08-25 22:37:55 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/60001
5 years, 4 months ago (2015-08-25 22:45:13 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/103453)
5 years, 4 months ago (2015-08-25 23:35:40 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/60001
5 years, 4 months ago (2015-08-26 00:21:48 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/75186)
5 years, 4 months ago (2015-08-26 01:18:01 UTC) #31
Yoav Weiss
On 2015/08/26 01:18:01, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 4 months ago (2015-08-26 08:52:01 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/80001
5 years, 3 months ago (2015-08-26 18:13:50 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104827)
5 years, 3 months ago (2015-08-26 18:39:21 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/80001
5 years, 3 months ago (2015-08-26 18:47:43 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/98887)
5 years, 3 months ago (2015-08-26 20:26:48 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/80001
5 years, 3 months ago (2015-08-26 21:02:09 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93250)
5 years, 3 months ago (2015-08-26 21:13:25 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/80001
5 years, 3 months ago (2015-08-26 22:22:32 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93319)
5 years, 3 months ago (2015-08-26 22:32:39 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/80001
5 years, 3 months ago (2015-08-26 22:33:26 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93326)
5 years, 3 months ago (2015-08-26 22:43:29 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314923005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314923005/80001
5 years, 3 months ago (2015-08-26 22:50:27 UTC) #55
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201259
5 years, 3 months ago (2015-08-26 22:55:59 UTC) #56
dstockwell
5 years, 3 months ago (2015-08-27 06:24:23 UTC) #57
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1318933002/ by dstockwell@chromium.org.

The reason for reverting is: Broke WebKit Linux Leak

See:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b....

Powered by Google App Engine
This is Rietveld 408576698