Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350933003: Implement MouseEvent.getModifierState (Closed)

Created:
5 years, 3 months ago by dtapuska
Modified:
5 years, 3 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, vivekg, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement MouseEvent.getModifierState Move the getModifierState implementation from the KeyboardEvent into the UIEventWithKeyState object. Expose the getModiferState method in the MouseEvent.idl. BUG=532963 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202581

Patch Set 1 #

Patch Set 2 : Add LayoutTests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -18 lines) Patch
A LayoutTests/fast/events/mouseevent-getModifierState.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/mouseevent-getModifierState-expected.txt View 1 1 chunk +135 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 2 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/KeyboardEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/KeyboardEvent.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/events/MouseEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/UIEventWithKeyState.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/events/UIEventWithKeyState.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dtapuska
Need to wait for approval on intent to ship; https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/juYYZgLbzF4
5 years, 3 months ago (2015-09-17 16:56:26 UTC) #2
Rick Byers
LGTM But of course please wait for 2 more LGTMs on the intent before landing. ...
5 years, 3 months ago (2015-09-17 19:42:42 UTC) #3
dtapuska
https://codereview.chromium.org/1350933003/diff/20001/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt File LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt (right): https://codereview.chromium.org/1350933003/diff/20001/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt#newcode2918 LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:2918: method getModifierState On 2015/09/17 19:42:42, Rick Byers wrote: > ...
5 years, 3 months ago (2015-09-17 19:55:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350933003/20001
5 years, 3 months ago (2015-09-21 12:54:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/43231)
5 years, 3 months ago (2015-09-21 13:25:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350933003/20001
5 years, 3 months ago (2015-09-21 14:45:54 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 15:32:41 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202581

Powered by Google App Engine
This is Rietveld 408576698