Issue 1346153003: Add getModifierState to the MouseEvent for android_webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1346153003: Add getModifierState to the MouseEvent for android_webview. (Closed)

Created:
5 years, 3 months ago by dtapuska

Modified:
5 years, 3 months ago

Reviewers:
timvolodine

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add getModifierState to the MouseEvent for android_webview. This is a reflection of blink change landing https://codereview.chromium.org/1350933003/ BUG=532963, 506603 R=timvolodine@chromium.org Committed: https://crrev.com/6ced5d624c786faee2d6adb502f0eff4cf1d9572 Cr-Commit-Position: refs/heads/master@{#349934}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

timvolodine

lgtm thanks! could you please add BUG 506603 to the description as well before committing.

5 years, 3 months ago (2015-09-18 10:59:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346153003/1

5 years, 3 months ago (2015-09-21 15:39:54 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-09-21 15:53:34 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6ced5d624c786faee2d6adb502f0eff4cf1d9572
Cr-Commit-Position: refs/heads/master@{#349934}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages