Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1350883002: Fix bug where setting canvas size to 0 was treated as if context was lost (Closed)

Created:
5 years, 3 months ago by Justin Novosad
Modified:
5 years, 3 months ago
Reviewers:
Stephen White
CC:
blink-reviews, dshwang, blink-reviews-html_chromium.org, dglazkov+blink, Rik, Justin Novosad
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix bug where setting canvas size to 0 was treated as if context was lost The canvas context lost handling logic was falsely kicking, rendering the canvas unusable when setting one of its dimensions to zero. BUG=532148 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202645

Patch Set 1 #

Patch Set 2 : fix layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
A LayoutTests/fast/canvas/bug532148.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/bug532148-expected.html View 1 chunk +16 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-lose-restore-googol-size.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
Justin Novosad
PTAL
5 years, 3 months ago (2015-09-16 19:43:08 UTC) #2
Stephen White
LGTM
5 years, 3 months ago (2015-09-16 19:50:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350883002/1
5 years, 3 months ago (2015-09-16 20:00:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/114462)
5 years, 3 months ago (2015-09-16 20:48:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350883002/20001
5 years, 3 months ago (2015-09-22 18:23:20 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 21:06:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202645

Powered by Google App Engine
This is Rietveld 408576698