Source/core/html/HTMLCanvasElement.cpp - Issue 1350883002: Fix bug where setting canvas size to 0 was treated as if context was lost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCanvasElement.cpp

Issue 1350883002: Fix bug where setting canvas size to 0 was treated as if context was lost (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix layout test Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLCanvasElement.cpp

diff --git a/Source/core/html/HTMLCanvasElement.cpp b/Source/core/html/HTMLCanvasElement.cpp

index 6dc6f92d1556336a741cd0d237d79c7bb972ab68..fc74f13b75eaf385ef5ef2d985b8cbc77280ab6c 100644

--- a/Source/core/html/HTMLCanvasElement.cpp

+++ b/Source/core/html/HTMLCanvasElement.cpp

@@ -692,7 +692,7 @@ PassOwnPtr<ImageBufferSurface> HTMLCanvasElement::createImageBufferSurface(const

void HTMLCanvasElement::createImageBuffer()

{

createImageBufferInternal(nullptr);

- if (m_didFailToCreateImageBuffer && m_context->is2d())

+ if (m_didFailToCreateImageBuffer && m_context->is2d() && !size().isEmpty())

m_context->loseContext(CanvasRenderingContext::SyntheticLostContext);

}

« no previous file with comments | « LayoutTests/fast/canvas/canvas-lose-restore-googol-size.html ('k') | no next file » | no next file with comments »