Issue 1350703003: Don't pass null isolates to FXJS_ when we have a real isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1350703003: Don't pass null isolates to FXJS_ when we have a real isolate. (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't pass null isolates to FXJS_ when we have a real isolate. Kill some now unused functions as a result. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/34b39e1d4fa0b16d47770b823230344356cc451a

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -66 lines)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.cpp	View	4 chunks	+4 lines, -14 lines	1 comment	Download
M	fpdfsdk/src/javascript/JS_EventHandler.cpp	View	3 chunks	+13 lines, -31 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	2 chunks	+6 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

lgtm https://codereview.chromium.org/1350703003/diff/1/fpdfsdk/src/javascript/Field.cpp File fpdfsdk/src/javascript/Field.cpp (right): https://codereview.chromium.org/1350703003/diff/1/fpdfsdk/src/javascript/Field.cpp#newcode3521 fpdfsdk/src/javascript/Field.cpp:3521: nonstd::unique_ptr<CFX_WideString> pStr(swSort.GetAt(j)); I didn't see the delete / ...

5 years, 3 months ago (2015-09-17 00:10:23 UTC) #3

Tom Sepez

5 years, 3 months ago (2015-09-17 22:30:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
34b39e1d4fa0b16d47770b823230344356cc451a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages