fpdfsdk/include/jsapi/fxjs_v8.h - Issue 1350703003: Don't pass null isolates to FXJS_ when we have a real isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/jsapi/fxjs_v8.h

Issue 1350703003: Don't pass null isolates to FXJS_ when we have a real isolate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/jsapi/fxjs_v8.h

diff --git a/fpdfsdk/include/jsapi/fxjs_v8.h b/fpdfsdk/include/jsapi/fxjs_v8.h

index 3499bfbfea63793f2ed3e8a0f5f8342280e1385c..a1541593a1c3b2f44b35eea87e40dddc12bec709 100644

--- a/fpdfsdk/include/jsapi/fxjs_v8.h

+++ b/fpdfsdk/include/jsapi/fxjs_v8.h

@@ -125,9 +125,7 @@ const wchar_t* FXJS_GetTypeof(v8::Local<v8::Value> pObj);

void FXJS_SetPrivate(v8::Isolate* pIsolate,

v8::Local<v8::Object> pObj,

void* p);

-void FXJS_SetPrivate(v8::Local<v8::Object> pObj, void* p);

void* FXJS_GetPrivate(v8::Isolate* pIsolate, v8::Local<v8::Object> pObj);

-void* FXJS_GetPrivate(v8::Local<v8::Object> pObj);

void FXJS_FreePrivate(void* p);

void FXJS_FreePrivate(v8::Local<v8::Object> pObj);

« no previous file with comments | « no previous file | fpdfsdk/src/javascript/Document.cpp » ('j') | fpdfsdk/src/javascript/Field.cpp » ('J')