content/browser/web_contents/web_contents_impl.h - Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index d0a567006d8bf7563f6a2c30446e78d4853d1bb4..d677ee2602d55928518151f1704ad9e38a1bcca4 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -517,7 +517,6 @@ class CONTENT_EXPORT WebContentsImpl

void DidStartNavigation(NavigationHandle* navigation_handle) override;

void DidRedirectNavigation(NavigationHandle* navigation_handle) override;

void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override;

- void DidCommitNavigation(NavigationHandle* navigation_handle) override;

void DidFinishNavigation(NavigationHandle* navigation_handle) override;

void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,

const GURL& validated_url,