Remove WebContentsObserver::DidCommitNavigation

content/public/browser/navigation_handle.h

Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 49d0884de43256e204ad3159903db42e889d1af6..e31469f89587c70350d7077a3097a5fb58431d23 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -11,6 +11,7 @@
 class GURL;
 
 namespace content {
+class RenderFrameHost;
 
 // A NavigationHandle tracks information related to a single navigation.
 class CONTENT_EXPORT NavigationHandle {
@@ -28,11 +29,15 @@ class CONTENT_EXPORT NavigationHandle {
   // Whether the navigation is taking place in the main frame or in a subframe.
   virtual bool IsInMainFrame() const = 0;
 
-  // Whether the navigation has successfully committed a document.
-  virtual bool HasCommittedDocument() const = 0;
+  // Returns the RenderFrameHost this navigation is taking place in. This can
+  // only be accessed after the navigation is ready to commit.
+  virtual RenderFrameHost* GetRenderFrameHost() = 0;
 
-  // Whether an error page has committed for the navigation.
-  virtual bool HasCommittedErrorPage() const = 0;
+  // Whether the navigation has committed.

[Charlie Reis, 2015/09/21 16:40:42]

Please also mention that this returns true for either successful commits or
error pages that replace the previous page (distinguished by |IsErrorPage|), and
false for errors that leave the user on the previous page.

(This is an important point for how to use the API correctly.)

[clamy, 2015/09/22 00:38:05]

Done.

+  virtual bool HasCommitted() = 0;
+
+  // Whether the navigation resulted in an error page.
+  virtual bool IsErrorPage() = 0;
 };
 
 }  // namespace content