content/browser/frame_host/navigation_request.cc - Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index a99074f2ce3aeb56440b44cc0e9530f0f0c1db39..b38889847121b6d9bf86418d4ab80efae1d71021 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -204,6 +204,8 @@ void NavigationRequest::CreateNavigationHandle(NavigatorDelegate* delegate) {

void NavigationRequest::TransferNavigationHandleOwnership(

RenderFrameHostImpl* render_frame_host) {

render_frame_host->SetNavigationHandle(navigation_handle_.Pass());

+ render_frame_host->navigation_handle()->ReadyToCommitNavigation(

+ render_frame_host);

}

void NavigationRequest::OnRequestRedirected(