Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Side by Side Diff: content/browser/frame_host/navigator_delegate.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "content/public/browser/invalidate_type.h" 9 #include "content/public/browser/invalidate_type.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
(...skipping 19 matching lines...) Expand all
30 // Called when a navigation started. The same NavigationHandle will be 30 // Called when a navigation started. The same NavigationHandle will be
31 // provided for events related to the same navigation. 31 // provided for events related to the same navigation.
32 virtual void DidStartNavigation(NavigationHandle* navigation_handle) {} 32 virtual void DidStartNavigation(NavigationHandle* navigation_handle) {}
33 33
34 // Called when a navigation was redirected. 34 // Called when a navigation was redirected.
35 virtual void DidRedirectNavigation(NavigationHandle* navigation_handle) {} 35 virtual void DidRedirectNavigation(NavigationHandle* navigation_handle) {}
36 36
37 // Called when the navigation is about to be committed in a renderer. 37 // Called when the navigation is about to be committed in a renderer.
38 virtual void ReadyToCommitNavigation(NavigationHandle* navigation_handle) {} 38 virtual void ReadyToCommitNavigation(NavigationHandle* navigation_handle) {}
39 39
40 // Called when a navigation committed.
41 virtual void DidCommitNavigation(NavigationHandle* navigation_handle) {}
42
43 // Called when a document load resulting from the navigation stopped. Note 40 // Called when a document load resulting from the navigation stopped. Note
nasko 2015/09/18 16:42:16 Let's update the comment. We don't track document
clamy 2015/09/18 20:37:33 Done.
44 // that |navigation_handle| will be destroyed at the end of this call. 41 // that |navigation_handle| will be destroyed at the end of this call.
45 virtual void DidFinishNavigation(NavigationHandle* navigation_handle) {} 42 virtual void DidFinishNavigation(NavigationHandle* navigation_handle) {}
46 43
47 // TODO(clamy): all methods below that are related to navigation 44 // TODO(clamy): all methods below that are related to navigation
48 // events should go away in favor of the ones above. 45 // events should go away in favor of the ones above.
49 46
50 // The RenderFrameHost started a provisional load for the frame 47 // The RenderFrameHost started a provisional load for the frame
51 // represented by |render_frame_host|. 48 // represented by |render_frame_host|.
52 virtual void DidStartProvisionalLoad( 49 virtual void DidStartProvisionalLoad(
53 RenderFrameHostImpl* render_frame_host, 50 RenderFrameHostImpl* render_frame_host,
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 // throbber stopping. 127 // throbber stopping.
131 virtual void DidStopLoading() {} 128 virtual void DidStopLoading() {}
132 129
133 // The load progress was changed. 130 // The load progress was changed.
134 virtual void DidChangeLoadProgress() {} 131 virtual void DidChangeLoadProgress() {}
135 }; 132 };
136 133
137 } // namspace content 134 } // namspace content
138 135
139 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 136 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698