content/test/web_contents_observer_sanity_checker.h - Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/web_contents_observer_sanity_checker.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/web_contents_observer_sanity_checker.h

diff --git a/content/test/web_contents_observer_sanity_checker.h b/content/test/web_contents_observer_sanity_checker.h

index e5508d3ee3a6d78996b15f87485fb592ef36c6ac..aa7c9b24b5b10c8e0ad0ec0867e23653b7c18af6 100644

--- a/content/test/web_contents_observer_sanity_checker.h

+++ b/content/test/web_contents_observer_sanity_checker.h

@@ -43,7 +43,6 @@ class WebContentsObserverSanityChecker : public WebContentsObserver,

void DidStartNavigation(NavigationHandle* navigation_handle) override;

void DidRedirectNavigation(NavigationHandle* navigation_handle) override;

void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override;

- void DidCommitNavigation(NavigationHandle* navigation_handle) override;

void DidFinishNavigation(NavigationHandle* navigation_handle) override;

void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,

const GURL& validated_url,

@@ -95,14 +94,12 @@ class WebContentsObserverSanityChecker : public WebContentsObserver,

void AssertMainFrameExists();

bool NavigationIsOngoing(NavigationHandle* navigation_handle);

- bool NavigationIsOngoingAndCommitted(NavigationHandle* navigation_handle);

std::set<std::pair<int, int>> current_hosts_;

std::set<std::pair<int, int>> live_routes_;

std::set<std::pair<int, int>> deleted_routes_;

std::set<NavigationHandle*> ongoing_navigations_;

- std::set<NavigationHandle*> ongoing_committed_navigations_;

bool web_contents_destroyed_;