Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: content/test/web_contents_observer_sanity_checker.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_ 5 #ifndef CONTENT_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_
6 #define CONTENT_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_ 6 #define CONTENT_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 25 matching lines...) Expand all
36 void RenderFrameCreated(RenderFrameHost* render_frame_host) override; 36 void RenderFrameCreated(RenderFrameHost* render_frame_host) override;
37 void RenderFrameDeleted(RenderFrameHost* render_frame_host) override; 37 void RenderFrameDeleted(RenderFrameHost* render_frame_host) override;
38 void RenderFrameForInterstitialPageCreated( 38 void RenderFrameForInterstitialPageCreated(
39 RenderFrameHost* render_frame_host) override; 39 RenderFrameHost* render_frame_host) override;
40 void RenderFrameHostChanged(RenderFrameHost* old_host, 40 void RenderFrameHostChanged(RenderFrameHost* old_host,
41 RenderFrameHost* new_host) override; 41 RenderFrameHost* new_host) override;
42 void FrameDeleted(RenderFrameHost* render_frame_host) override; 42 void FrameDeleted(RenderFrameHost* render_frame_host) override;
43 void DidStartNavigation(NavigationHandle* navigation_handle) override; 43 void DidStartNavigation(NavigationHandle* navigation_handle) override;
44 void DidRedirectNavigation(NavigationHandle* navigation_handle) override; 44 void DidRedirectNavigation(NavigationHandle* navigation_handle) override;
45 void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override; 45 void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override;
46 void DidCommitNavigation(NavigationHandle* navigation_handle) override;
47 void DidFinishNavigation(NavigationHandle* navigation_handle) override; 46 void DidFinishNavigation(NavigationHandle* navigation_handle) override;
48 void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host, 47 void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
49 const GURL& validated_url, 48 const GURL& validated_url,
50 bool is_error_page, 49 bool is_error_page,
51 bool is_iframe_srcdoc) override; 50 bool is_iframe_srcdoc) override;
52 void DidCommitProvisionalLoadForFrame( 51 void DidCommitProvisionalLoadForFrame(
53 RenderFrameHost* render_frame_host, 52 RenderFrameHost* render_frame_host,
54 const GURL& url, 53 const GURL& url,
55 ui::PageTransition transition_type) override; 54 ui::PageTransition transition_type) override;
56 void DidFailProvisionalLoad(RenderFrameHost* render_frame_host, 55 void DidFailProvisionalLoad(RenderFrameHost* render_frame_host,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 87
89 private: 88 private:
90 explicit WebContentsObserverSanityChecker(WebContents* web_contents); 89 explicit WebContentsObserverSanityChecker(WebContents* web_contents);
91 ~WebContentsObserverSanityChecker() override; 90 ~WebContentsObserverSanityChecker() override;
92 91
93 std::string Format(RenderFrameHost* render_frame_host); 92 std::string Format(RenderFrameHost* render_frame_host);
94 void AssertRenderFrameExists(RenderFrameHost* render_frame_host); 93 void AssertRenderFrameExists(RenderFrameHost* render_frame_host);
95 void AssertMainFrameExists(); 94 void AssertMainFrameExists();
96 95
97 bool NavigationIsOngoing(NavigationHandle* navigation_handle); 96 bool NavigationIsOngoing(NavigationHandle* navigation_handle);
98 bool NavigationIsOngoingAndCommitted(NavigationHandle* navigation_handle);
99 97
100 std::set<std::pair<int, int>> current_hosts_; 98 std::set<std::pair<int, int>> current_hosts_;
101 std::set<std::pair<int, int>> live_routes_; 99 std::set<std::pair<int, int>> live_routes_;
102 std::set<std::pair<int, int>> deleted_routes_; 100 std::set<std::pair<int, int>> deleted_routes_;
103 101
104 std::set<NavigationHandle*> ongoing_navigations_; 102 std::set<NavigationHandle*> ongoing_navigations_;
105 std::set<NavigationHandle*> ongoing_committed_navigations_;
106 103
107 bool web_contents_destroyed_; 104 bool web_contents_destroyed_;
108 105
109 DISALLOW_COPY_AND_ASSIGN(WebContentsObserverSanityChecker); 106 DISALLOW_COPY_AND_ASSIGN(WebContentsObserverSanityChecker);
110 }; 107 };
111 108
112 } // namespace content 109 } // namespace content
113 110
114 #endif // CONTENT_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_ 111 #endif // CONTENT_TEST_WEB_CONTENTS_OBSERVER_SANITY_CHECKER_H_
OLDNEW
« no previous file with comments | « content/public/browser/web_contents_observer.h ('k') | content/test/web_contents_observer_sanity_checker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698