chrome/browser/captive_portal/captive_portal_tab_helper.h - Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/captive_portal/captive_portal_tab_helper.h

diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper.h b/chrome/browser/captive_portal/captive_portal_tab_helper.h

index 965c994a98a11b3db89379099dca6dbea4f8f7de..853cf710f7ee0719fe21c9f5617094743326beab 100644

--- a/chrome/browser/captive_portal/captive_portal_tab_helper.h

+++ b/chrome/browser/captive_portal/captive_portal_tab_helper.h

@@ -66,10 +66,9 @@ class CaptivePortalTabHelper

content::NavigationHandle* navigation_handle) override;

void DidRedirectNavigation(

content::NavigationHandle* navigation_handle) override;

- void DidCommitNavigation(

- content::NavigationHandle* navigation_handle) override;

void DidFinishNavigation(

content::NavigationHandle* navigation_handle) override;

+ void DidStopLoading() override;

// content::NotificationObserver:

void Observe(int type,

« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_tab_helper.cc » ('j') | no next file with comments »