Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/captive_portal/captive_portal_tab_helper.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_tab_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_
6 #define CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_ 6 #define CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 public base::NonThreadSafe, 59 public base::NonThreadSafe,
60 public content::WebContentsUserData<CaptivePortalTabHelper> { 60 public content::WebContentsUserData<CaptivePortalTabHelper> {
61 public: 61 public:
62 ~CaptivePortalTabHelper() override; 62 ~CaptivePortalTabHelper() override;
63 63
64 // content::WebContentsObserver: 64 // content::WebContentsObserver:
65 void DidStartNavigation( 65 void DidStartNavigation(
66 content::NavigationHandle* navigation_handle) override; 66 content::NavigationHandle* navigation_handle) override;
67 void DidRedirectNavigation( 67 void DidRedirectNavigation(
68 content::NavigationHandle* navigation_handle) override; 68 content::NavigationHandle* navigation_handle) override;
69 void DidCommitNavigation(
70 content::NavigationHandle* navigation_handle) override;
71 void DidFinishNavigation( 69 void DidFinishNavigation(
72 content::NavigationHandle* navigation_handle) override; 70 content::NavigationHandle* navigation_handle) override;
71 void DidStopLoading() override;
73 72
74 // content::NotificationObserver: 73 // content::NotificationObserver:
75 void Observe(int type, 74 void Observe(int type,
76 const content::NotificationSource& source, 75 const content::NotificationSource& source,
77 const content::NotificationDetails& details) override; 76 const content::NotificationDetails& details) override;
78 77
79 // Called when a certificate interstitial error page is about to be shown. 78 // Called when a certificate interstitial error page is about to be shown.
80 void OnSSLCertError(const net::SSLInfo& ssl_info); 79 void OnSSLCertError(const net::SSLInfo& ssl_info);
81 80
82 // A "Login Tab" is a tab that was originally at a captive portal login 81 // A "Login Tab" is a tab that was originally at a captive portal login
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 // Neither of these will ever be NULL. 117 // Neither of these will ever be NULL.
119 scoped_ptr<CaptivePortalTabReloader> tab_reloader_; 118 scoped_ptr<CaptivePortalTabReloader> tab_reloader_;
120 scoped_ptr<CaptivePortalLoginDetector> login_detector_; 119 scoped_ptr<CaptivePortalLoginDetector> login_detector_;
121 120
122 content::NotificationRegistrar registrar_; 121 content::NotificationRegistrar registrar_;
123 122
124 DISALLOW_COPY_AND_ASSIGN(CaptivePortalTabHelper); 123 DISALLOW_COPY_AND_ASSIGN(CaptivePortalTabHelper);
125 }; 124 };
126 125
127 #endif // CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_ 126 #endif // CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698