Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1350283003: Buildbot spec and gyp defs for SK_USE_DISCARDABLE_SCALEDIMAGECACHE bot (Closed)

Created:
5 years, 3 months ago by borenet
Modified:
5 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Buildbot spec and gyp defs for SK_USE_DISCARDABLE_SCALEDIMAGECACHE bot BUG=skia:4354 Committed: https://skia.googlesource.com/skia/+/9063e427d209d703bf9326f186f72061928c59c2

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Backpedal #

Patch Set 4 : line break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -0 lines) Patch
M tools/buildbot_spec.json View 1 2 1 chunk +180 lines, -0 lines 0 comments Download
M tools/buildbot_spec.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
borenet
I think this is all that's needed for the new bot.
5 years, 3 months ago (2015-09-18 12:38:47 UTC) #2
borenet
On 2015/09/18 12:38:47, borenet wrote: > I think this is all that's needed for the ...
5 years, 3 months ago (2015-09-18 12:39:05 UTC) #3
mtklein
lgtm Here I was thinking you'd set up the bots to parse the bot extra_config ...
5 years, 3 months ago (2015-09-18 12:42:20 UTC) #4
borenet
On 2015/09/18 12:42:20, mtklein wrote: > lgtm > > Here I was thinking you'd set ...
5 years, 3 months ago (2015-09-18 12:52:57 UTC) #5
mtklein
On 2015/09/18 12:52:57, borenet wrote: > On 2015/09/18 12:42:20, mtklein wrote: > > lgtm > ...
5 years, 3 months ago (2015-09-18 12:54:00 UTC) #6
borenet
This CL is unnecessary now, due to Mike's https://codereview.chromium.org/1346833004. I changed it in patch set ...
5 years, 3 months ago (2015-09-18 13:22:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350283003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350283003/40001
5 years, 3 months ago (2015-09-18 13:26:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2721)
5 years, 3 months ago (2015-09-18 13:27:35 UTC) #12
mtklein
lgtm
5 years, 3 months ago (2015-09-18 13:28:23 UTC) #14
borenet
On 2015/09/18 13:27:35, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 3 months ago (2015-09-18 13:31:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350283003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350283003/60001
5 years, 3 months ago (2015-09-18 13:31:20 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 13:37:17 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9063e427d209d703bf9326f186f72061928c59c2

Powered by Google App Engine
This is Rietveld 408576698