Test-...-Release-SK_FOO --> -DSK_FOO

Test-...-Release-SK_FOO --> -DSK_FOO

When a bot ends with extra_config SK_LIKE_THIS,
we'll define SK_LIKE_THIS when compiling.

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

BUG=skia:4354
Committed: https://skia.googlesource.com/skia/+/d0fff5b6d81a557715869c9ad1fc22b10ea9c7f1

[mtklein_C, 2015-09-18 13:02:29]

mtklein@chromium.org changed reviewers:
+ borenet@google.com

[mtklein_C, 2015-09-18 13:03:47]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 13:03:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346833004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346833004/20001

[borenet, 2015-09-18 13:06:09]

https://codereview.chromium.org/1346833004/diff/20001/tools/buildbot_spec.json
File tools/buildbot_spec.json (right):

https://codereview.chromium.org/1346833004/diff/20001/tools/buildbot_spec.jso...
tools/buildbot_spec.json:2913: "CPPFLAGS": "-DSKNX_NO_SIMD",
AFAIK this is not precedented: all of the bots currently use GYP_DEFINES to
plumb through and determine which defines actually get set.  Just for the
record.

[mtklein_C, 2015-09-18 13:06:14]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 13:06:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346833004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346833004/40001

[borenet, 2015-09-18 13:06:24]

(LGTM)

[commit-bot: I haz the power, 2015-09-18 13:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 13:07:23]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein_C, 2015-09-18 13:07:35]

On 2015/09/18 13:06:09, borenet wrote:
> https://codereview.chromium.org/1346833004/diff/20001/tools/buildbot_spec.json
> File tools/buildbot_spec.json (right):
> 
>
https://codereview.chromium.org/1346833004/diff/20001/tools/buildbot_spec.jso...
> tools/buildbot_spec.json:2913: "CPPFLAGS": "-DSKNX_NO_SIMD",
> AFAIK this is not precedented: all of the bots currently use GYP_DEFINES to
> plumb through and determine which defines actually get set.  Just for the
> record.

Seems tedious though, right?  CPPFLAGS works fine for defines, and that way we
don't need GYP flags for every little #define we might want to set.

(PS3 adds an intentional compile failure to double check the define ends up on
the command line correctly.  PS2 is still the real deal.)

[borenet, 2015-09-18 13:08:32]

On 2015/09/18 13:07:35, mtklein_C wrote:
> On 2015/09/18 13:06:09, borenet wrote:
> >
https://codereview.chromium.org/1346833004/diff/20001/tools/buildbot_spec.json
> > File tools/buildbot_spec.json (right):
> > 
> >
>
https://codereview.chromium.org/1346833004/diff/20001/tools/buildbot_spec.jso...
> > tools/buildbot_spec.json:2913: "CPPFLAGS": "-DSKNX_NO_SIMD",
> > AFAIK this is not precedented: all of the bots currently use GYP_DEFINES to
> > plumb through and determine which defines actually get set.  Just for the
> > record.
> 
> Seems tedious though, right?  CPPFLAGS works fine for defines, and that way we
> don't need GYP flags for every little #define we might want to set.
> 

Yeah, especially if we're going to start supporting multiple build systems.  It
makes sense not to have to do different types of plumbing for every one.

> (PS3 adds an intentional compile failure to double check the define ends up on
> the command line correctly.  PS2 is still the real deal.)

[mtklein_C, 2015-09-18 13:09:05]

> (PS3 adds an intentional compile failure to double check the define ends up on
> the command line correctly.  PS2 is still the real deal.)

Looks good.

[mtklein_C, 2015-09-18 13:09:37]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2015-09-18 13:09:37]

The patchset sent to the CQ was uploaded after l-g-t-m from borenet@google.com
Link to the patchset: https://codereview.chromium.org/1346833004/#ps60001
(title: "undo")

[commit-bot: I haz the power, 2015-09-18 13:09:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346833004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346833004/60001

[commit-bot: I haz the power, 2015-09-18 13:16:00]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d0fff5b6d81a557715869c9ad1fc22b10ea9c7f1