Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350183004: DevTools: CSS.getMatchedStylesForNode protocol command to return inline styles (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: CSS.getMatchedStylesForNode protocol command to return inline styles The change populates CSS.getMatchedStylesForNode with inline styles for the selected node. This makes CSS.getInlineStylesForNode not needed as far as front-end will start to cache the responses of |getMatchedStylesForNode| command. BUG=527993 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202547

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -174 lines) Patch
M LayoutTests/inspector/elements/styles-2/get-set-stylesheet-text.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-3/selector-source-data.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-4/styles-history.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-4/styles-new-API.html View 1 5 chunks +4 lines, -14 lines 0 comments Download
M LayoutTests/inspector/elements/styles-4/styles-source-offsets.html View 1 1 chunk +4 lines, -32 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 chunks +38 lines, -30 lines 0 comments Download
M Source/devtools/front_end/audits/AuditRules.js View 2 chunks +5 lines, -14 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 4 chunks +12 lines, -74 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 3 chunks +15 lines, -6 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1349293005 Patch 20001

Messages

Total messages: 9 (3 generated)
lushnikov
ptal
5 years, 3 months ago (2015-09-18 01:25:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350183004/20001
5 years, 3 months ago (2015-09-18 05:13:53 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 07:50:19 UTC) #5
pfeldman
lgtm
5 years, 3 months ago (2015-09-18 20:52:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350183004/20001
5 years, 3 months ago (2015-09-18 21:00:01 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 21:06:44 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202547

Powered by Google App Engine
This is Rietveld 408576698