Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1349293005: DevTools: slightly cleanup WI.CSSRule interface (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: slightly cleanup WI.CSSRule interface It turned out that nobody is interested in rule's frameId. BUG=527993 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202500

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M LayoutTests/http/tests/inspector/modify-cross-domain-rule.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 1 3 chunks +20 lines, -17 lines 0 comments Download

Dependent Patchsets:

Issue 1350183004 Patch 1
Issue 1350183004 Patch 20001

Messages

Total messages: 6 (2 generated)
lushnikov
5 years, 3 months ago (2015-09-17 23:14:13 UTC) #2
pfeldman
lgtm
5 years, 3 months ago (2015-09-18 00:26:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349293005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349293005/20001
5 years, 3 months ago (2015-09-18 01:09:49 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 03:39:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202500

Powered by Google App Engine
This is Rietveld 408576698