Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350183002: EDK: More scoped_ptr -> std::unique_ptr conversions. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : gah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -123 lines) Patch
M mojo/edk/embedder/platform_shared_buffer.h View 2 chunks +7 lines, -5 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer.h View 2 chunks +7 lines, -5 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer_posix.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer_unittest.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M mojo/edk/system/core.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 1 8 chunks +16 lines, -15 lines 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M mojo/edk/system/mapping_table.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/mapping_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 1 5 chunks +9 lines, -6 lines 0 comments Download
M mojo/edk/system/message_in_transit.h View 3 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/raw_channel_posix.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/transport_data.h View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
5 years, 3 months ago (2015-09-17 23:15:50 UTC) #1
viettrungluu
oops, wrong email address
5 years, 3 months ago (2015-09-17 23:23:44 UTC) #3
vardhan
lgtm
5 years, 3 months ago (2015-09-17 23:31:37 UTC) #4
viettrungluu
5 years, 3 months ago (2015-09-17 23:39:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
dce872885269a7a35163e4afdc36d8ab43aaae9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698