Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: mojo/edk/system/mapping_table.h

Issue 1350183002: EDK: More scoped_ptr -> std::unique_ptr conversions. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: gah Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/system/local_data_pipe_impl.cc ('k') | mojo/edk/system/mapping_table.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_EDK_SYSTEM_MAPPING_TABLE_H_ 5 #ifndef MOJO_EDK_SYSTEM_MAPPING_TABLE_H_
6 #define MOJO_EDK_SYSTEM_MAPPING_TABLE_H_ 6 #define MOJO_EDK_SYSTEM_MAPPING_TABLE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory>
10 #include <vector> 11 #include <vector>
11 12
12 #include "base/containers/hash_tables.h" 13 #include "base/containers/hash_tables.h"
13 #include "base/memory/scoped_ptr.h"
14 #include "mojo/edk/system/system_impl_export.h" 14 #include "mojo/edk/system/system_impl_export.h"
15 #include "mojo/public/c/system/types.h" 15 #include "mojo/public/c/system/types.h"
16 #include "mojo/public/cpp/system/macros.h" 16 #include "mojo/public/cpp/system/macros.h"
17 17
18 namespace mojo { 18 namespace mojo {
19 19
20 namespace embedder { 20 namespace embedder {
21 class PlatformSharedBufferMapping; 21 class PlatformSharedBufferMapping;
22 } 22 }
23 23
(...skipping 12 matching lines...) Expand all
36 // 36 //
37 // This class is NOT thread-safe; locking is left to |Core|. 37 // This class is NOT thread-safe; locking is left to |Core|.
38 class MOJO_SYSTEM_IMPL_EXPORT MappingTable { 38 class MOJO_SYSTEM_IMPL_EXPORT MappingTable {
39 public: 39 public:
40 MappingTable(); 40 MappingTable();
41 ~MappingTable(); 41 ~MappingTable();
42 42
43 // Tries to add a mapping. (Takes ownership of the mapping in all cases; on 43 // Tries to add a mapping. (Takes ownership of the mapping in all cases; on
44 // failure, it will be destroyed.) 44 // failure, it will be destroyed.)
45 MojoResult AddMapping( 45 MojoResult AddMapping(
46 scoped_ptr<embedder::PlatformSharedBufferMapping> mapping); 46 std::unique_ptr<embedder::PlatformSharedBufferMapping> mapping);
47 MojoResult RemoveMapping(uintptr_t address); 47 MojoResult RemoveMapping(uintptr_t address);
48 48
49 private: 49 private:
50 friend bool internal::ShutdownCheckNoLeaks(Core*); 50 friend bool internal::ShutdownCheckNoLeaks(Core*);
51 51
52 // TODO(vtl): Should the value type be |std::unique_ptr|?
52 using AddressToMappingMap = 53 using AddressToMappingMap =
53 base::hash_map<uintptr_t, embedder::PlatformSharedBufferMapping*>; 54 base::hash_map<uintptr_t, embedder::PlatformSharedBufferMapping*>;
54 AddressToMappingMap address_to_mapping_map_; 55 AddressToMappingMap address_to_mapping_map_;
55 56
56 MOJO_DISALLOW_COPY_AND_ASSIGN(MappingTable); 57 MOJO_DISALLOW_COPY_AND_ASSIGN(MappingTable);
57 }; 58 };
58 59
59 } // namespace system 60 } // namespace system
60 } // namespace mojo 61 } // namespace mojo
61 62
62 #endif // MOJO_EDK_SYSTEM_MAPPING_TABLE_H_ 63 #endif // MOJO_EDK_SYSTEM_MAPPING_TABLE_H_
OLDNEW
« no previous file with comments | « mojo/edk/system/local_data_pipe_impl.cc ('k') | mojo/edk/system/mapping_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698