[runtime] Replace COMPARE/COMPARE_STRONG with proper Object::Compare.

[runtime] Replace COMPARE/COMPARE_STRONG with proper Object::Compare.

This removes the weird COMPARE and COMPARE_STRONG JavaScript builtins
and replaces them with a proper C++ implementation in Object::Compare
and appropriate wrappers Object::LessThan, Object::GreaterThan, and
friends that are intended to be used by a true/false returning CompareIC
in the future, as well as the interpreter.  As a short-term solution we
provide %Compare and %Compare_Strong entry points for the current
CompareIC that return the appropriate integer values expected by
fullcodegen currently.

Now the Abstract Relational Comparison is also using the correct
ToPrimitive implementation, which properly supports @@toPrimitive.

BUG=v8:4307
LOG=n

Committed: https://crrev.com/593c655a3c814277283f9fa1520d5ce59d6b019c
Cr-Commit-Position: refs/heads/master@{#30816}

[Benedikt Meurer, 2015-09-17 18:23:28]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-17 18:23:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1350113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1350113002/1

[Benedikt Meurer, 2015-09-17 18:23:58]

Orion, Ross: FYI

[commit-bot: I haz the power, 2015-09-17 18:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 18:26:20]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_win64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/8784)

[Benedikt Meurer, 2015-09-18 02:05:59]

Patchset #1 (id:1) has been deleted

[Benedikt Meurer, 2015-09-18 02:06:04]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 02:06:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1350113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1350113002/20001

[Benedikt Meurer, 2015-09-18 02:20:29]

Patchset #1 (id:20001) has been deleted

[Benedikt Meurer, 2015-09-18 02:20:35]

Patchset #1 (id:40001) has been deleted

[Benedikt Meurer, 2015-09-18 02:20:40]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 02:20:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1350113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1350113002/60001

[commit-bot: I haz the power, 2015-09-18 02:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 02:31:29]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Benedikt Meurer, 2015-09-18 04:10:22]

Patchset #1 (id:60001) has been deleted

[Benedikt Meurer, 2015-09-18 04:22:58]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2015-09-18 04:22:58]

Hey Jaro,

The last spec operation builtin gone! Woohoo!
Please take a look.

Thanks,
Benedikt

[Jarin, 2015-09-18 06:34:06]

lgtm

[Benedikt Meurer, 2015-09-18 06:34:17]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-09-18 06:34:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1350113002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1350113002/80001

[commit-bot: I haz the power, 2015-09-18 06:35:43]

Committed patchset #1 (id:80001)

[commit-bot: I haz the power, 2015-09-18 06:35:58]

Patchset 1 (id:??) landed as
https://crrev.com/593c655a3c814277283f9fa1520d5ce59d6b019c
Cr-Commit-Position: refs/heads/master@{#30816}

[conradw, 2015-09-18 08:59:21]

conradw@chromium.org changed reviewers:
+ conradw@chromium.org

[conradw, 2015-09-18 08:59:22]

https://codereview.chromium.org/1350113002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1350113002/diff/80001/src/objects.cc#newcode202
src/objects.cc:202: Strength strength) {
We've been trying to use the Strength enum only for weak vs strong mode objects
(the name could possibly be reverted back to ObjectStrength), rather than for
messaging the current language mode, see Runtime_GetProperty. Using the
LanguageMode enum here instead would fit better with that.

https://codereview.chromium.org/1350113002/diff/80001/src/objects.cc#newcode223
src/objects.cc:223: Isolate* const isolate =
Handle<HeapObject>::cast(x)->GetIsolate();
Can the isolates ever be different here?

[Benedikt Meurer, 2015-09-18 09:52:03]

https://codereview.chromium.org/1350113002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1350113002/diff/80001/src/objects.cc#newcode202
src/objects.cc:202: Strength strength) {
On 2015/09/18 08:59:22, conradw wrote:
> We've been trying to use the Strength enum only for weak vs strong mode
objects
> (the name could possibly be reverted back to ObjectStrength), rather than for
> messaging the current language mode, see Runtime_GetProperty. Using the
> LanguageMode enum here instead would fit better with that.

Hm, that was totally non obvious from the comment on enum class Strength?!

https://codereview.chromium.org/1350113002/diff/80001/src/objects.cc#newcode223
src/objects.cc:223: Isolate* const isolate =
Handle<HeapObject>::cast(x)->GetIsolate();
On 2015/09/18 08:59:22, conradw wrote:
> Can the isolates ever be different here?

No, but either x or y can be a Smi and therefore the cast would fail.