Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Side by Side Diff: src/mips64/code-stubs-mips64.cc

Issue 1350113002: [runtime] Replace COMPARE/COMPARE_STRONG with proper Object::Compare. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 719
720 __ bind(&slow); 720 __ bind(&slow);
721 // Prepare for call to builtin. Push object pointers, a0 (lhs) first, 721 // Prepare for call to builtin. Push object pointers, a0 (lhs) first,
722 // a1 (rhs) second. 722 // a1 (rhs) second.
723 __ Push(lhs, rhs); 723 __ Push(lhs, rhs);
724 // Figure out which native to call and setup the arguments. 724 // Figure out which native to call and setup the arguments.
725 if (cc == eq) { 725 if (cc == eq) {
726 __ TailCallRuntime(strict() ? Runtime::kStrictEquals : Runtime::kEquals, 2, 726 __ TailCallRuntime(strict() ? Runtime::kStrictEquals : Runtime::kEquals, 2,
727 1); 727 1);
728 } else { 728 } else {
729 int context_index = is_strong(strength())
730 ? Context::COMPARE_STRONG_BUILTIN_INDEX
731 : Context::COMPARE_BUILTIN_INDEX;
732 int ncr; // NaN compare result. 729 int ncr; // NaN compare result.
733 if (cc == lt || cc == le) { 730 if (cc == lt || cc == le) {
734 ncr = GREATER; 731 ncr = GREATER;
735 } else { 732 } else {
736 DCHECK(cc == gt || cc == ge); // Remaining cases. 733 DCHECK(cc == gt || cc == ge); // Remaining cases.
737 ncr = LESS; 734 ncr = LESS;
738 } 735 }
739 __ li(a0, Operand(Smi::FromInt(ncr))); 736 __ li(a0, Operand(Smi::FromInt(ncr)));
740 __ push(a0); 737 __ push(a0);
741 738
742 // Call the native; it returns -1 (less), 0 (equal), or 1 (greater) 739 // Call the native; it returns -1 (less), 0 (equal), or 1 (greater)
743 // tagged as a small integer. 740 // tagged as a small integer.
744 __ InvokeBuiltin(context_index, JUMP_FUNCTION); 741 __ TailCallRuntime(
742 is_strong(strength()) ? Runtime::kCompare_Strong : Runtime::kCompare, 3,
743 1);
745 } 744 }
746 745
747 __ bind(&miss); 746 __ bind(&miss);
748 GenerateMiss(masm); 747 GenerateMiss(masm);
749 } 748 }
750 749
751 750
752 void StoreRegistersStateStub::Generate(MacroAssembler* masm) { 751 void StoreRegistersStateStub::Generate(MacroAssembler* masm) {
753 __ mov(t9, ra); 752 __ mov(t9, ra);
754 __ pop(ra); 753 __ pop(ra);
(...skipping 5010 matching lines...) Expand 10 before | Expand all | Expand 10 after
5765 MemOperand(fp, 6 * kPointerSize), NULL); 5764 MemOperand(fp, 6 * kPointerSize), NULL);
5766 } 5765 }
5767 5766
5768 5767
5769 #undef __ 5768 #undef __
5770 5769
5771 } // namespace internal 5770 } // namespace internal
5772 } // namespace v8 5771 } // namespace v8
5773 5772
5774 #endif // V8_TARGET_ARCH_MIPS64 5773 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/objects.h » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698