Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart

Issue 1350053002: Add "environment" parameter to spawnUri for String.fromEnvironment support. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
index 70eda5b5e973708798fe729f2faf6b5eec296c82..f33a264597db0c357d9766d745694245ad878167 100644
--- a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
@@ -63,12 +63,14 @@ class Isolate {
static Future<Isolate> spawnUri(
Uri uri, List<String> args, var message,
{bool paused: false,
+ SendPort onExit,
+ SendPort onError,
+ bool errorsAreFatal,
bool checked,
+ Map<String, String> environment,
Uri packageRoot,
- Map<String, Uri> packages,
- bool errorsAreFatal,
- SendPort onExit,
- SendPort onError}) {
+ Map<String, Uri> packages}) {
+ if (environment != null) throw new UnimplementedError("environment");
if (packageRoot != null) throw new UnimplementedError("packageRoot");
if (packages != null) throw new UnimplementedError("packages");
bool forcePause = (errorsAreFatal != null) ||
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | sdk/lib/core/bool.dart » ('j') | sdk/lib/core/bool.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698