Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: runtime/lib/isolate_patch.dart

Issue 1350053002: Add "environment" parameter to spawnUri for String.fromEnvironment support. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/js_runtime/lib/isolate_patch.dart » ('j') | sdk/lib/core/bool.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/isolate_patch.dart
diff --git a/runtime/lib/isolate_patch.dart b/runtime/lib/isolate_patch.dart
index 51b7ac0123147c1e9103d2875bf0efae471fcf42..daaaf9729f1444dffe5bd40ce83e7a2a53809c99 100644
--- a/runtime/lib/isolate_patch.dart
+++ b/runtime/lib/isolate_patch.dart
@@ -309,13 +309,15 @@ patch class Isolate {
/* patch */ static Future<Isolate> spawnUri(
Uri uri, List<String> args, var message,
{bool paused: false,
+ SendPort onExit,
+ SendPort onError,
+ bool errorsAreFatal,
bool checked,
+ Map<String, String> environment,
Uri packageRoot,
- Map<String, Uri> packages,
- bool errorsAreFatal,
- SendPort onExit,
- SendPort onError}) {
+ Map<String, Uri> packages}) {
RawReceivePort readyPort;
+ if (environment != null) throw new UnimplementedError("environment");
try {
// The VM will invoke [_startIsolate] and not `main`.
// TODO: Handle [packages].
« no previous file with comments | « no previous file | sdk/lib/_internal/js_runtime/lib/isolate_patch.dart » ('j') | sdk/lib/core/bool.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698