Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2571)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1349933003: GN: Simplify config by unconditionalising a flag that nacl-clang recognises (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index f7797958044ce13f30fbba5f579e81fd282ed097..764a56bcb0f170b66823c2b8c2b26e9d4dcbb48d 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -935,18 +935,10 @@ if (is_clang) {
# TODO(thakis): Remove, http://crbug.com/263960
"-Wno-reserved-user-defined-literal",
- ]
- # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
- # always have different versions. Certain flags may not be recognized by
- # one version or the other.
- if (!is_nacl) {
- # Flags NaCl does not recognize.
- default_warning_flags += [
- # TODO(hans): Get this cleaned up.
- "-Wno-inconsistent-missing-override",
- ]
- }
+ # TODO(hans): Get this cleaned up.
+ "-Wno-inconsistent-missing-override",
+ ]
}
# chromium_code ---------------------------------------------------------------
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698