Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1349933003: GN: Simplify config by unconditionalising a flag that nacl-clang recognises (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 917 matching lines...) Expand 10 before | Expand all | Expand 10 after
928 # http://crbug.com/255186 928 # http://crbug.com/255186
929 "-Wno-deprecated-register", 929 "-Wno-deprecated-register",
930 930
931 # TODO(thakis): This used to be implied by -Wno-unused-function, 931 # TODO(thakis): This used to be implied by -Wno-unused-function,
932 # which we no longer use. Check if it makes sense to remove 932 # which we no longer use. Check if it makes sense to remove
933 # this as well. http://crbug.com/316352 933 # this as well. http://crbug.com/316352
934 "-Wno-unneeded-internal-declaration", 934 "-Wno-unneeded-internal-declaration",
935 935
936 # TODO(thakis): Remove, http://crbug.com/263960 936 # TODO(thakis): Remove, http://crbug.com/263960
937 "-Wno-reserved-user-defined-literal", 937 "-Wno-reserved-user-defined-literal",
938
939 # TODO(hans): Get this cleaned up.
940 "-Wno-inconsistent-missing-override",
938 ] 941 ]
939
940 # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
941 # always have different versions. Certain flags may not be recognized by
942 # one version or the other.
943 if (!is_nacl) {
944 # Flags NaCl does not recognize.
945 default_warning_flags += [
946 # TODO(hans): Get this cleaned up.
947 "-Wno-inconsistent-missing-override",
948 ]
949 }
950 } 942 }
951 943
952 # chromium_code --------------------------------------------------------------- 944 # chromium_code ---------------------------------------------------------------
953 # 945 #
954 # Toggles between higher and lower warnings for code that is (or isn't) 946 # Toggles between higher and lower warnings for code that is (or isn't)
955 # part of Chromium. 947 # part of Chromium.
956 948
957 config("chromium_code") { 949 config("chromium_code") {
958 if (is_win) { 950 if (is_win) {
959 cflags = [ "/W4" ] # Warning level 4. 951 cflags = [ "/W4" ] # Warning level 4.
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
1253 cflags += [ "-gsplit-dwarf" ] 1245 cflags += [ "-gsplit-dwarf" ]
1254 } 1246 }
1255 } 1247 }
1256 } 1248 }
1257 1249
1258 config("no_symbols") { 1250 config("no_symbols") {
1259 if (!is_win) { 1251 if (!is_win) {
1260 cflags = [ "-g0" ] 1252 cflags = [ "-g0" ]
1261 } 1253 }
1262 } 1254 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698