Issue 1349933003: GN: Simplify config by unconditionalising a flag that nacl-clang recognises

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1349933003: GN: Simplify config by unconditionalising a flag that nacl-clang recognises (Closed)

Created:
5 years, 3 months ago by Mark Seaborn

Modified:
5 years, 3 months ago

Reviewers:
Sean Klein

CC:
mojo-reviews_chromium.org, Petr Hosek

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

GN: Simplify config by unconditionalising a flag that nacl-clang recognises Use of the flag "-Wno-inconsistent-missing-override" no longer needs to be conditionalised. This is also a step towards getting Skia to build with the (P)NaCl toolchains, because Skia currently needs to be compiled with this warning disabled. BUG=https://github.com/domokit/mojo/issues/431 TEST=build R=smklein@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f4a956fc257ccb0db3c4669af89b3b4c4ce168e2

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	build/config/compiler/BUILD.gn	View		1 chunk	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Seaborn

I'll upstream this in https://codereview.chromium.org/1351683004/.

5 years, 3 months ago (2015-09-17 18:14:55 UTC) #2

Mark Seaborn

5 years, 3 months ago (2015-09-18 17:55:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f4a956fc257ccb0db3c4669af89b3b4c4ce168e2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages