Display active mixed content as error instead of info in WebsiteSettings

chrome/browser/ui/website_settings/website_settings_ui.cc

Index: chrome/browser/ui/website_settings/website_settings_ui.cc
diff --git a/chrome/browser/ui/website_settings/website_settings_ui.cc b/chrome/browser/ui/website_settings/website_settings_ui.cc
index 05d04d09b4ce76474db18d8188f4be724d7247b5..2056f10f8c3b4bee56e2f94268d06d12d22e2032 100644
--- a/chrome/browser/ui/website_settings/website_settings_ui.cc
+++ b/chrome/browser/ui/website_settings/website_settings_ui.cc
@@ -351,12 +351,10 @@ int WebsiteSettingsUI::GetConnectionIconID(
     case WebsiteSettings::SITE_CONNECTION_STATUS_UNENCRYPTED:
       resource_id = IDR_PAGEINFO_WARNING_MAJOR;
       break;
+    case WebsiteSettings::SITE_CONNECTION_STATUS_MIXED_SCRIPT:
     case WebsiteSettings::SITE_CONNECTION_STATUS_ENCRYPTED_ERROR:
       resource_id = IDR_PAGEINFO_BAD;
       break;
-    default:

[estark, 2015/09/16 21:32:08]

deleted this case because if it hadn't been here, a compile error would have
caught this bug when SITE_CONNECTION_STATUS_MIXED_SCRIPT was added

[felt, 2015/09/17 17:18:56]

good call. I'm surprised we didn't see any reports of the NOTREACHED() being
hit, tho

[estark, 2015/09/17 17:22:19]

Huh, that is surprising. Then again, I don't think this bug had hit beta yet,
plus you'd only hit the NOTREACHED() if you had let active mixed content run
(which we know almost nobody does) and then opened website settings. So maybe
it's not that surprising.

-      NOTREACHED();
-      break;
   }
   return resource_id;
 }