Display active mixed content as error instead of info in WebsiteSettings

chrome/browser/ui/website_settings/website_settings_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/website_settings/website_settings_ui.h"
 
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/content_settings/core/browser/plugins_field_trial.h"
 #include "grit/theme_resources.h"
@@ skipping 333 matching lines @@
       break;
     case WebsiteSettings::SITE_CONNECTION_STATUS_ENCRYPTED:
       resource_id = IDR_PAGEINFO_GOOD;
       break;
     case WebsiteSettings::SITE_CONNECTION_STATUS_MIXED_CONTENT:
       resource_id = IDR_PAGEINFO_WARNING_MINOR;
       break;
     case WebsiteSettings::SITE_CONNECTION_STATUS_UNENCRYPTED:
       resource_id = IDR_PAGEINFO_WARNING_MAJOR;
       break;
+    case WebsiteSettings::SITE_CONNECTION_STATUS_MIXED_SCRIPT:
     case WebsiteSettings::SITE_CONNECTION_STATUS_ENCRYPTED_ERROR:
       resource_id = IDR_PAGEINFO_BAD;
       break;
-    default:

[estark, 2015/09/16 21:32:08]

deleted this case because if it hadn't been here, a compile error would have
caught this bug when SITE_CONNECTION_STATUS_MIXED_SCRIPT was added

[felt, 2015/09/17 17:18:56]

good call. I'm surprised we didn't see any reports of the NOTREACHED() being
hit, tho

[estark, 2015/09/17 17:22:19]

Huh, that is surprising. Then again, I don't think this bug had hit beta yet,
plus you'd only hit the NOTREACHED() if you had let active mixed content run
(which we know almost nobody does) and then opened website settings. So maybe
it's not that surprising.

-      NOTREACHED();
-      break;
   }
   return resource_id;
 }
 
 // static
 const gfx::Image& WebsiteSettingsUI::GetConnectionIcon(
     WebsiteSettings::SiteConnectionStatus status) {
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
   return rb.GetNativeImageNamed(GetConnectionIconID(status));
 }