Display active mixed content as error instead of info in WebsiteSettings

Display active mixed content as error instead of info in WebsiteSettings

The introduction of the SITE_CONNECTION_STATUS_MIXED_SCRIPT enum value
got left out of some places where error condition values are
listed. This CL fixes this so that active mixed content shows up as a
red error icon instead of a blue informational icon in WebsiteSettings.

BUG=529569
Committed: https://crrev.com/f62683e313ae2d324cd91333d4e8d273bc8e77a8
Cr-Commit-Position: refs/heads/master@{#349444}

[estark, 2015-09-16 21:32:08]

estark@chromium.org changed reviewers:
+ felt@chromium.org

[estark, 2015-09-16 21:32:09]

felt, PTAL?

https://codereview.chromium.org/1349843003/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings_ui.cc (left):

https://codereview.chromium.org/1349843003/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings_ui.cc:357: default:
deleted this case because if it hadn't been here, a compile error would have
caught this bug when SITE_CONNECTION_STATUS_MIXED_SCRIPT was added

[felt, 2015-09-17 17:18:56]

lgtm

https://codereview.chromium.org/1349843003/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings_ui.cc (left):

https://codereview.chromium.org/1349843003/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings_ui.cc:357: default:
On 2015/09/16 21:32:08, estark wrote:
> deleted this case because if it hadn't been here, a compile error would have
> caught this bug when SITE_CONNECTION_STATUS_MIXED_SCRIPT was added

good call. I'm surprised we didn't see any reports of the NOTREACHED() being
hit, tho

[estark, 2015-09-17 17:22:19]

Thanks!

https://codereview.chromium.org/1349843003/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings_ui.cc (left):

https://codereview.chromium.org/1349843003/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings_ui.cc:357: default:
On 2015/09/17 17:18:56, felt wrote:
> On 2015/09/16 21:32:08, estark wrote:
> > deleted this case because if it hadn't been here, a compile error would have
> > caught this bug when SITE_CONNECTION_STATUS_MIXED_SCRIPT was added
> 
> good call. I'm surprised we didn't see any reports of the NOTREACHED() being
> hit, tho

Huh, that is surprising. Then again, I don't think this bug had hit beta yet,
plus you'd only hit the NOTREACHED() if you had let active mixed content run
(which we know almost nobody does) and then opened website settings. So maybe
it's not that surprising.

[estark, 2015-09-17 17:22:32]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2015-09-17 17:23:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1349843003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1349843003/20001

[commit-bot: I haz the power, 2015-09-17 17:52:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-17 17:52:48]

Patchset 2 (id:??) landed as
https://crrev.com/f62683e313ae2d324cd91333d4e8d273bc8e77a8
Cr-Commit-Position: refs/heads/master@{#349444}