Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: content/renderer/p2p/empty_network_manager.h

Issue 1349823004: Check media permissions (mic/camera) before exposing local addresses to WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/p2p/empty_network_manager.h
diff --git a/content/renderer/p2p/empty_network_manager.h b/content/renderer/p2p/empty_network_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..fcc02f4f015a122d9d04b3f3829d7468a678e29c
--- /dev/null
+++ b/content/renderer/p2p/empty_network_manager.h
@@ -0,0 +1,56 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// A NetworkManager implementation which handles the case where local address
+// enumeration is not requested and just returns empty network lists. This class
+// is not thread safe and should only be used by WebRTC's worker thread.
+
+#ifndef CONTENT_RENDERER_P2P_EMPTY_NETWORK_MANAGER_H_
+#define CONTENT_RENDERER_P2P_EMPTY_NETWORK_MANAGER_H_
+
+#include "base/memory/weak_ptr.h"
+#include "base/single_thread_task_runner.h"
+#include "base/time/time.h"
+#include "content/common/content_export.h"
+#include "third_party/webrtc/base/network.h"
+#include "third_party/webrtc/base/sigslot.h"
+#include "url/gurl.h"
+
+namespace rtc {
+class NetworkManager;
+} // namespace rtc
+
+namespace content {
+
+class EmptyNetworkManager : public rtc::NetworkManagerBase,
+ public base::SupportsWeakPtr<EmptyNetworkManager>,
Sergey Ulanov 2015/09/21 22:12:58 It's preferrable to use WeakPtrFactory instead of
guoweis_left_chromium 2015/09/22 17:56:56 Done.
+ public sigslot::has_slots<> {
Sergey Ulanov 2015/09/21 22:12:58 Don't need has_slots<>
guoweis_left_chromium 2015/09/22 17:56:56 Done.
+ public:
+ // This class is created by WebRTC's signaling thread but used by WebRTC's
+ // worker thread |task_runner|.
+ CONTENT_EXPORT EmptyNetworkManager(
Sergey Ulanov 2015/09/21 22:12:58 Mark the whole class as CONTENT_EXPORT?
guoweis_left_chromium 2015/09/22 17:56:56 Done.
+ const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);
+
+ CONTENT_EXPORT ~EmptyNetworkManager() override;
+
+ // rtc::NetworkManager:
+ void StartUpdating() override;
+ void StopUpdating() override;
+ void GetNetworks(NetworkList* networks) const override;
+
+ private:
+ void FireEvent(bool first_time);
+ void SendNetworksChangedSignal();
+
+ const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+
+ // Track how long it takes for client to receive SignalNetworksChanged.
+ base::TimeTicks start_updating_time_;
+
+ DISALLOW_COPY_AND_ASSIGN(EmptyNetworkManager);
+};
+
+} // namespace content
+
+#endif // CONTENT_RENDERER_P2P_EMPTY_NETWORK_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698