Check media permissions (mic/camera) before exposing local addresses to WebRTC.

content/renderer/p2p/empty_network_manager.cc

Index: content/renderer/p2p/empty_network_manager.cc
diff --git a/content/renderer/p2p/empty_network_manager.cc b/content/renderer/p2p/empty_network_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f5de504cc4ebfb599a9597b2d58f959b46485992
--- /dev/null
+++ b/content/renderer/p2p/empty_network_manager.cc
@@ -0,0 +1,62 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/p2p/empty_network_manager.h"
+
+#include "base/bind.h"
+#include "base/location.h"
+#include "base/logging.h"
+#include "base/thread_task_runner_handle.h"
+#include "content/renderer/p2p/network_manager_uma.h"
+
+namespace content {
+
+EmptyNetworkManager::EmptyNetworkManager(
+    const scoped_refptr<base::SingleThreadTaskRunner>& task_runner)

[Sergey Ulanov, 2015/09/21 22:12:58]

You use |task_runner| just to check that this class is used on the right thread.
Use base::ThreadChecker for that. You just need to call DetachFromThread() in
the constructor. Then it will be attached automatically to the next thread this
class is called on.

[guoweis_left_chromium, 2015/09/22 17:56:56]

Done.

+    : task_runner_(task_runner) {
+  set_enumeration_permission(ENUMERATION_BLOCKED);
+}
+
+EmptyNetworkManager::~EmptyNetworkManager() {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+}
+
+void EmptyNetworkManager::StartUpdating() {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+
+  bool first_time = start_updating_time_.is_null();
+
+  if (first_time)
+    start_updating_time_ = base::TimeTicks::Now();

[Sergey Ulanov, 2015/09/21 22:12:58]

I don't think you actually need to store this value. Instead just store a
boolean flag to remember that the event has been fired.

[guoweis_left_chromium, 2015/09/22 17:56:56]

Done.

+
+  FireEvent(first_time);
+}
+
+void EmptyNetworkManager::StopUpdating() {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+}
+
+void EmptyNetworkManager::GetNetworks(NetworkList* networks) const {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+  if (!networks)

[Sergey Ulanov, 2015/09/21 22:12:58]

Do we expect |networks| to be nullptr?

[guoweis_left_chromium, 2015/09/22 17:56:56]

Done.

+    return;
+
+  networks->clear();
+}
+
+void EmptyNetworkManager::FireEvent(bool first_time) {
+  if (first_time)
+    ReportIPPermissionStatus(PERMISSION_NOT_REQUESTED);
+
+  // Post a task to avoid reentrancy.
+  base::ThreadTaskRunnerHandle::Get()->PostTask(
+      FROM_HERE,
+      base::Bind(&EmptyNetworkManager::SendNetworksChangedSignal, AsWeakPtr()));
+}
+
+void EmptyNetworkManager::SendNetworksChangedSignal() {
+  SignalNetworksChanged();
+}
+
+}  // namespace content